Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): properly propagate the FirebaseAuthMultiFactorException for all reauthenticate and link methods #9700

Merged
merged 4 commits into from
Oct 24, 2022

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Oct 10, 2022

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

fixes #9402

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Salakar Salakar changed the title fix(auth): properly propagate the FirebaseAuthMultiFactorException for all reauthenticate and link methods fix(auth): properly propagate the FirebaseAuthMultiFactorException for all reauthenticate and link methods Oct 24, 2022
@Lyokone Lyokone merged commit 9ad97c8 into master Oct 24, 2022
@Lyokone Lyokone deleted the fix/9402 branch October 24, 2022 12:48
@firebase firebase locked and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_auth] MFA enabled user calls reauthenticateWithCredential method throws FirebaseAuthException.
4 participants